inji.Chats.get - Code Metrics - Inspection of "formating" - injitools/cms-Inji - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — master (ebb499)

by Alexey

created 2016-11-29 15:13 UTC

inji.Chats.get A

↳ Parent: system/modules/Chats/static/js/chat.js

Complexity

Conditions	3
Paths	9

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	3
nc	9
nop	2
dl	0
loc	67
rs	9.2815
c	0
b	0
f	0

3 Functions

Rating	Size	Complexity
B	27	1
A	10	1
A	8	1

How to fix Long Method

inji.Chats = {};
inji.Chats.chats = [];
inji.Chats.get = function (id, params) {
  var chatElement = $('#' + id);
  var chat;

  if (chatElement.data('chats-index') === undefined) {
    inji.Chats.chats.push({
      element: chatElement,
      timer: null,
      chatId: chatElement.data('chat-id'),
      msgCount: chatElement.data('msg-count'),
      perPage: 20,
      lastEventDate: chatElement.data('last-event-date'),
      reverse: params.reverse ? true : false,
      scrollable: true,
      members: {},
      checkoutMembers: function () {
        var members = this.members;
        $.each($('[data-chat_member_status'), function () {
          var el = $(this);
          if (members[el.data('chat_member_status')]) {
            if (el.data('ontext')) {
              el.html(el.data('ontext'));
            }
            if (el.data('onclass')) {
              if (el.data('offclass') && el.hasClass(el.data('offclass'))) {
                el.removeClass(el.data('offclass'));
              }
              el.addClass(el.data('onclass'));
            }
          } else {
            if (el.data('offtext')) {
              el.html(el.data('offtext'));
            }
            if (el.data('offclass')) {
              if (el.data('onclass') && el.hasClass(el.data('onclass'))) {
                el.removeClass(el.data('onclass'));
              }
              el.addClass(el.data('offclass'));
            }
          }
        })
      },
      deleteMsg: function (id, chatId) {
        inji.Server.request({
          url: 'chats/deleteMsg/' + id,
          success: function () {
            $('#chat' + chatId + 'msg' + id).remove();
          }
        });
      },
      banUser: function (msgId, chatId) {
        inji.Server.request({
          url: 'chats/banUser/' + msgId,
          success: function (msgIds) {
            for (var key in msgIds) {
var someObject;
for (var key in someObject) {
    if ( ! someObject.hasOwnProperty(key)) {
        continue; // Skip keys from the prototype.
    }

    doSomethingWith(key);
}
              $('#chat' + chatId + 'msg' + key).remove();
            }
          }
        });
      },
    });
    var index = inji.Chats.chats.length - 1
    chatElement.data('chats-index', index);
    inji.Chats.init(index);
    return inji.Chats.chats[index];
  }
  return inji.Chats.chats[chatElement.data('chats-index')];
}
inji.Chats.init = function (chatIndex) {
  var updater = function () {
    inji.Server.request({
      url: 'chats/events/' + inji.Chats.chats[chatIndex].chatId,
      data: {
        lastEventDate: inji.Chats.chats[chatIndex].lastEventDate
      },
      success: function (data) {
        inji.Chats.chats[chatIndex].members = data.members;
        inji.Chats.chats[chatIndex].checkoutMembers();
        for (key in data.messages) {

          var msg = data.messages[key];
          inji.Chats.chats[chatIndex].lastEventDate = msg.message.chat_message_date_create;
          var template = inji.Chats.chats[chatIndex].element.find('.chats-chat-message-template').html();
          template = template.replace(/message-id/g, msg.message.chat_message_id);
          template = template.replace(/message-userId/g, msg.message.chat_message_user_id);
          template = template.replace(/message-date_create/g, msg.message.chat_message_date_create);
          template = template.replace(/user-firstName/g, msg.userFirstName);
          template = template.replace(/user-fullName/g, msg.fullUserName);
          template = template.replace(/user-photo/g, msg.userPhoto);
          template = template.replace(/message-text/g, msg.message.chat_message_text);
          var messageList = inji.Chats.chats[chatIndex].element.find('.chats-chat-messageList');
          if (inji.Chats.chats[chatIndex].reverse) {
            messageList.append(template);
            if (inji.Chats.chats[chatIndex].scrollable) {
              var height = messageList.height() + messageList.scrollTop() + parseInt(messageList.css('paddingTop')) + parseInt(messageList.css('paddingBottom'));
              messageList.scrollTop(messageList[0].scrollHeight);
            }
          } else {
            messageList.prepend(template);
          }
        }

        var allMsgs = inji.Chats.chats[chatIndex].element.find('.chats-chat-messageList>*');
        if (allMsgs.length > 20) {
          var i = 0;
          if (inji.Chats.chats[chatIndex].reverse) {
            var diff = allMsgs.length - 20;
            while (i <= diff && i >= 0) {
              $(allMsgs[i]).remove();
              i--;
            }
          } else {
            i = allMsgs.length + 1;
            while (i > 20 && allMsgs[i]) {
              $(allMsgs[i]).remove();
              i++;
            }
          }
        }
      }
    });
  };
  updater();
  inji.Chats.chats[chatIndex].timer = setInterval(updater, 5000);
}
inji.Chats.sendForm = function (form, id) {
  var chat = inji.Chats.get(id);
  var formData = new FormData(form);
  inji.Server.request({
    url: '/chats/sendForm/' + chat.element.data('chat-id'),
    type: 'POST',
    data: formData,
    processData: false,
  });
}

1			inji.Chats = {};
2			inji.Chats.chats = [];
3			inji.Chats.get = function (id, params) {
4			var chatElement = $('#' + id);
5			var chat;
			0 ignored issues – show Unused Code introduced 2016-11-29 14:48 UTC by Report Bug Copy Issue Report The variable `chat` seems to be never used. Consider removing it. Loading history...
6			if (chatElement.data('chats-index') === undefined) {
7			inji.Chats.chats.push({
8			element: chatElement,
9			timer: null,
10			chatId: chatElement.data('chat-id'),
11			msgCount: chatElement.data('msg-count'),
12			perPage: 20,
13			lastEventDate: chatElement.data('last-event-date'),
14			reverse: params.reverse ? true : false,
15			scrollable: true,
16			members: {},
17			checkoutMembers: function () {
18			var members = this.members;
19			$.each($('[data-chat_member_status'), function () {
20			var el = $(this);
21			if (members[el.data('chat_member_status')]) {
22			if (el.data('ontext')) {
23			el.html(el.data('ontext'));
24			}
25			if (el.data('onclass')) {
26			if (el.data('offclass') && el.hasClass(el.data('offclass'))) {
27			el.removeClass(el.data('offclass'));
28			}
29			el.addClass(el.data('onclass'));
30			}
31			} else {
32			if (el.data('offtext')) {
33			el.html(el.data('offtext'));
34			}
35			if (el.data('offclass')) {
36			if (el.data('onclass') && el.hasClass(el.data('onclass'))) {
37			el.removeClass(el.data('onclass'));
38			}
39			el.addClass(el.data('offclass'));
40			}
41			}
42			})
43			},
44			deleteMsg: function (id, chatId) {
45			inji.Server.request({
46			url: 'chats/deleteMsg/' + id,
47			success: function () {
48			$('#chat' + chatId + 'msg' + id).remove();
49			}
50			});
51			},
52			banUser: function (msgId, chatId) {
53			inji.Server.request({
54			url: 'chats/banUser/' + msgId,
55			success: function (msgIds) {
56			for (var key in msgIds) {
			0 ignored issues – show Complexity introduced 2016-11-29 14:48 UTC by Report Bug Copy Issue Report A for in loop automatically includes the property of any prototype object, consider checking the key using `hasOwnProperty`. When iterating over the keys of an object, this includes not only the keys of the object, but also keys contained in the prototype of that object. It is generally a best practice to check for these keys specifically: var someObject; for (var key in someObject) { if ( ! someObject.hasOwnProperty(key)) { continue; // Skip keys from the prototype. } doSomethingWith(key); } Loading history...
57			$('#chat' + chatId + 'msg' + key).remove();
58			}
59			}
60			});
61			},
62			});
63			var index = inji.Chats.chats.length - 1
64			chatElement.data('chats-index', index);
65			inji.Chats.init(index);
66			return inji.Chats.chats[index];
67			}
68			return inji.Chats.chats[chatElement.data('chats-index')];
69			}
70			inji.Chats.init = function (chatIndex) {
71			var updater = function () {
72			inji.Server.request({
73			url: 'chats/events/' + inji.Chats.chats[chatIndex].chatId,
74			data: {
75			lastEventDate: inji.Chats.chats[chatIndex].lastEventDate
76			},
77			success: function (data) {
78			inji.Chats.chats[chatIndex].members = data.members;
79			inji.Chats.chats[chatIndex].checkoutMembers();
80			for (key in data.messages) {
			0 ignored issues – show Bug introduced 2016-11-29 14:48 UTC by Report Bug Copy Issue Report The variable `key` seems to be never declared. Assigning variables without defining them first makes them global. If this was intended, consider making it explicit like using `window.key`. Loading history...
81			var msg = data.messages[key];
82			inji.Chats.chats[chatIndex].lastEventDate = msg.message.chat_message_date_create;
83			var template = inji.Chats.chats[chatIndex].element.find('.chats-chat-message-template').html();
84			template = template.replace(/message-id/g, msg.message.chat_message_id);
85			template = template.replace(/message-userId/g, msg.message.chat_message_user_id);
86			template = template.replace(/message-date_create/g, msg.message.chat_message_date_create);
87			template = template.replace(/user-firstName/g, msg.userFirstName);
88			template = template.replace(/user-fullName/g, msg.fullUserName);
89			template = template.replace(/user-photo/g, msg.userPhoto);
90			template = template.replace(/message-text/g, msg.message.chat_message_text);
91			var messageList = inji.Chats.chats[chatIndex].element.find('.chats-chat-messageList');
92			if (inji.Chats.chats[chatIndex].reverse) {
93			messageList.append(template);
94			if (inji.Chats.chats[chatIndex].scrollable) {
95			var height = messageList.height() + messageList.scrollTop() + parseInt(messageList.css('paddingTop')) + parseInt(messageList.css('paddingBottom'));
96			messageList.scrollTop(messageList[0].scrollHeight);
97			}
98			} else {
99			messageList.prepend(template);
100			}
101			}
102
103			var allMsgs = inji.Chats.chats[chatIndex].element.find('.chats-chat-messageList>*');
104			if (allMsgs.length > 20) {
105			var i = 0;
106			if (inji.Chats.chats[chatIndex].reverse) {
107			var diff = allMsgs.length - 20;
108			while (i <= diff && i >= 0) {
109			$(allMsgs[i]).remove();
110			i--;
111			}
112			} else {
113			i = allMsgs.length + 1;
114			while (i > 20 && allMsgs[i]) {
115			$(allMsgs[i]).remove();
116			i++;
117			}
118			}
119			}
120			}
121			});
122			};
123			updater();
124			inji.Chats.chats[chatIndex].timer = setInterval(updater, 5000);
125			}
126			inji.Chats.sendForm = function (form, id) {
127			var chat = inji.Chats.get(id);
128			var formData = new FormData(form);
129			inji.Server.request({
130			url: '/chats/sendForm/' + chat.element.data('chat-id'),
131			type: 'POST',
132			data: formData,
133			processData: false,
134			});
135			}

injitools / cms-Inji

Branch — master (ebb499)

inji.Chats.get A

Complexity

Size

Duplication

Importance

3 Functions

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like